imay commented on a change in pull request #368: Add a frontend interface for
committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r239093417
##########
File path:
fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
##########
@@ -186,11 +195,11 @@ public void deleteTransaction(long transactionId) {
* @note callers should get db.write lock before call this api
*/
public void commitTransaction(long dbId, long transactionId,
List<TabletCommitInfo> tabletCommitInfos)
- throws MetaNotFoundException, TransactionCommitFailedException {
+ throws MetaNotFoundException, TransactionException {
Review comment:
I think you should add a parameter for `CommitAttachment`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
