kangpinghuang commented on a change in pull request #1200: Merge refactor code
into master
URL: https://github.com/apache/incubator-doris/pull/1200#discussion_r288466521
##########
File path: be/src/olap/cumulative_compaction.h
##########
@@ -133,46 +134,29 @@ class CumulativeCompaction {
OLAPStatus _validate_delete_file_action();
// 恢复header头文件的文件版本和table的data source
- OLAPStatus _roll_back(const std::vector<SegmentGroup*>& old_olap_indices);
-
- void _obtain_header_rdlock() {
- _table->obtain_header_rdlock();
- _header_locked = true;
- }
-
- void _obtain_header_wrlock() {
- _table->obtain_header_wrlock();
- _header_locked = true;
- }
-
- void _release_header_lock() {
- if (_header_locked) {
- _table->release_header_lock();
- _header_locked = false;
- }
- }
+ OLAPStatus _roll_back(std::vector<RowsetSharedPtr>& old_olap_indices);
Review comment:
```suggestion
OLAPStatus _roll_back(std::vector<RowsetSharedPtr>& ola_rowsets);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
