kangpinghuang commented on a change in pull request #1200: Merge refactor code
into master
URL: https://github.com/apache/incubator-doris/pull/1200#discussion_r288458681
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -729,7 +729,7 @@ Status
OlapScanNode::normalize_in_predicate(SlotDescriptor* slot, ColumnValueRan
// 1.3 Push InPredicate value into ColumnValueRange
HybirdSetBase::IteratorBase* iter =
pred->hybird_set()->begin();
while (iter->has_next()) {
- // column in (NULL,...) counldn't push down to OlapEngine
+ // column in (NULL,...) counldn't push down to
StorageEngine
// so that discard whole ColumnValueRange
if (NULL == iter->get_value()) {
Review comment:
```suggestion
if (iter->get_value() == nullptr) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
