imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315047014
##########
File path: be/src/olap/row.h
##########
@@ -142,7 +142,7 @@ template<typename RowType>
void agg_finalize_row(const std::vector<uint32_t>& ids, RowType* row) {
for (uint32_t id : ids) {
auto cell = row->cell(id);
- row->schema()->column(id)->agg_finalize(&cell);
+ row->schema()->column(id)->agg_finalize(&cell, row->arena());
Review comment:
If we use row's arena to do finalize. I'm afraid this arena will occupy a
lot of memory if it is finalized many times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
