imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315696818
##########
File path: be/src/olap/row.h
##########
@@ -75,7 +75,7 @@ template<typename DstRowType, typename SrcRowType>
void init_row_with_others(DstRowType* dst, const SrcRowType& src) {
for (auto cid : dst->schema()->column_ids()) {
auto dst_cell = dst->cell(cid);
- dst->schema()->column(cid)->agg_init(&dst_cell, src.cell(cid));
+ dst->schema()->column(cid)->agg_init(&dst_cell, src.cell(cid),
dst->arena());
Review comment:
I think we can make Arena be an argument of this function not assume it in
the row.
If we do so, all row should have an arena interface which is not very good.
If we support constant row used as filter condition later, there may be no need
to have an Arena.
And as an augment can make it more flexible, for example we can store some
rows in one block which share an arena.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
