imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315716956
##########
File path: be/src/exec/olap_scanner.cpp
##########
@@ -328,6 +328,11 @@ Status OlapScanner::get_batch(
slot->ptr = reinterpret_cast<char*>(v);
}
}
+
+ // the memory allocate by _read_row_cursor arena has been
copied,
+ // so we should release these memory immediately
+ _read_row_cursor.reset_arena();
Review comment:
You should do this in another place who will do aggregate finalize too. such
as be/src/olap/merger.cpp which is used to do compaction
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
