imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315714288
##########
File path: be/src/olap/schema.h
##########
@@ -78,16 +98,22 @@ class Schema {
~Schema();
- void reset(const std::vector<Field>& cols, size_t num_key_columns);
+ void reset_field(const std::vector<TabletColumn>& columns,
Review comment:
you should write some comments for reset_field and reset function. And I
think these functions should be as private. If we want let people reset this
schema, we should provide another function wrapper these two functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
