imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316943418
##########
File path: be/src/util/bitmap.h
##########
@@ -248,6 +250,144 @@ class Bitmap {
static const int64_t BIT_INDEX_MASK = 63;
};
+enum BitmapDataType {
Review comment:
1. It's better to put this enum in class RoaringBitmap
2. INT32 -> SINGLE ?
3. Because this will be persisted, it's better to write SINGLE = 1 BITMAP = 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
