Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/868#discussion_r126832672
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -314,6 +370,31 @@ public void deleteAllOptions(OptionType type) {
}
}
+ public void populateDefualtValues(Map<String, OptionValidator>
VALIDATORS) {
+
+ // populate the options from the config
+ final Map<String, OptionValidator> tmp = new HashMap<>();
--- End diff --
No need to create a new map. Setting the default value does not change the
key, so you can just update the fields of the value. (That is, we are not even
replacing the value; we are just altering a field in the value.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
