Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/868#discussion_r129929192
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValidator.java
 ---
    @@ -106,4 +107,16 @@ public boolean isAdminOption() {
        */
       public abstract Kind getKind();
     
    +  /**
    +   * Gets the default result option value for this validator.
    +   *
    +   * @return result default option value
    +   */
    +  public abstract void loadDefault(DrillConfig bootConfig);
    +
    +  /**
    +   * Sets the default result option value for this validator.
    +   */
    +  public abstract void setDefaultValue(OptionValue defaultValue);
    --- End diff --
    
    When would an external bit of code set this option? If this is called only 
from loadDefault(), go ahead and make the implementation private without a 
public API method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to