Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/868#discussion_r130186974
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -314,6 +344,19 @@ public void deleteAllOptions(OptionType type) {
}
}
+ public void populateDefaultValues() {
+
+ // populate the options from the config
+ final Map<String, OptionValidator> tmp = new HashMap<>();
+ for (OptionValidator validator: VALIDATORS.values()) {
+ try {
+ validator.loadDefault(bootConfig);
+ } catch (ConfigException.Missing e) {
+ throw new IllegalStateException("Config Option is missing"+e+
validator.getOptionName());
--- End diff --
`...missing " + validator.getOptionName()`
The exception adds no real value here. Or:
`new IllegalStateException(..., e);`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
