Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/868#discussion_r126829118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -201,9 +240,35 @@
public SystemOptionManager(LogicalPlanPersistence lpPersistence, final
PersistentStoreProvider provider) {
this.provider = provider;
- this.config =
PersistentStoreConfig.newJacksonBuilder(lpPersistence.getMapper(),
OptionValue.class)
- .name("sys.options")
- .build();
+ this.config =
PersistentStoreConfig.newJacksonBuilder(lpPersistence.getMapper(),
OptionValue.class)
--- End diff --
A really handy trick to avoid code duplication is this:
```
public SystemOptionManager(LogicalPlanPersistence lpPersistence, final
PersistentStoreProvider provider) {
this(lpPersistence, provider, null);
}
```
Then, the bulk of the constructor code appears only once: in the three-arg
version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
