Agirish commented on a change in pull request #1348: DRILL-6346: Create an 
Official Drill Docker Container
URL: https://github.com/apache/drill/pull/1348#discussion_r199228648
 
 

 ##########
 File path: distribution/Dockerfile
 ##########
 @@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM centos:7
+ARG VERSION
+
+RUN yum install -y java-1.8.0-openjdk-devel which ; yum clean all ; rm -rf 
/var/cache/yum
+
+COPY target/apache-drill-$VERSION.tar.gz /tmp
+RUN mkdir /opt/drill
+RUN tar -xvzf /tmp/apache-drill-$VERSION.tar.gz --directory=/opt/drill 
--strip-components 1
+
+ENTRYPOINT /opt/drill/bin/drill-embedded
 
 Review comment:
   So in the current implementation, when a user connects to the container 
using the docker run command, it will start Drill in embedded mode and go into 
the Sqlline prompt. Once they quit, the Drillbit process stops and container 
exits automatically. Each time with the docker run command, you get a Sqlline 
session. Please see the description above for an example. 
   
   In my original implementation, I have an init script which runs forever 
(keeping the container alive until someone explicitly stops it). That requires 
ZK. I discussed with Tim and we thought getting Embedded mode into Apache Drill 
codebase would be a good first step. And then we can discuss on the approach 
we'd like to take to get the stand-alone mode working. 
   
   See: 
https://github.com/Agirish/drill-containers/blob/master/dockerfiles/apache-drill-centos-1.13.0/init-script
   
https://github.com/Agirish/drill-containers/blob/master/dockerfiles/apache-zookeeper-centos-3.4.10/init-script

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to