Agirish commented on a change in pull request #1348: DRILL-6346: Create an 
Official Drill Docker Container
URL: https://github.com/apache/drill/pull/1348#discussion_r199272513
 
 

 ##########
 File path: distribution/pom.xml
 ##########
 @@ -485,6 +485,36 @@
         </plugins>
       </build>
     </profile>
+    <profile>
+      <!-- this profile adds/overrides few features of the 'apache-release'
+        profile in the parent pom. -->
+      <id>apache-release</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>com.spotify</groupId>
+            <artifactId>dockerfile-maven-plugin</artifactId>
+            <version>1.4.3</version>
+            <executions>
+              <execution>
+                <id>docker-image</id>
+                <goals>
 
 Review comment:
   Here is how we can explicitly build, tag and push (any one action at at 
time):
   
   Inside the distribution directory, executing:
   `mvn -Papache-release dockerfile:build`
   `mvn -Papache-release dockerfile:tag`
   `mvn -Papache-release dockerfile:push`
   
   Build and Tag happens on the user's system. Push pushes the image to the 
container registry on Docker Hub: 
https://hub.docker.com/r/drill/apache-drill-centos/tags/
   
   On the root directory, one can simply run the below command to build and tag 
the container. Can be optionally pushed to Docker Hub separately. 
    `mvn clean install -Papache-release -DskipTests`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to