Agirish commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348#discussion_r199325588
########## File path: distribution/Dockerfile ########## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +FROM centos:7 +ARG VERSION + +RUN yum install -y java-1.8.0-openjdk-devel which ; yum clean all ; rm -rf /var/cache/yum + +COPY target/apache-drill-$VERSION.tar.gz /tmp +RUN mkdir /opt/drill +RUN tar -xvzf /tmp/apache-drill-$VERSION.tar.gz --directory=/opt/drill --strip-components 1 + +ENTRYPOINT /opt/drill/bin/drill-embedded Review comment: But drill-localhost will not work right? That requires support for standalone mode - which requires ZK. Or am I missing something? Yes, with the current approach, the container is only alive until the embedded sqlline session is active. If they exit and reattach, they will get a new session (all history is lost). I could add an init script with an infinite wait, and suggest going the docker exec route, to keep the container alive and maintain history - but since it would still only support embedded mode (until we add support for standalone using ZK), i went with this approach. What do you suggest? One possibility, is we can document instructions on how to make changes to get what I suggested above working. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
