Agirish commented on a change in pull request #1348: DRILL-6346: Create an
Official Drill Docker Container
URL: https://github.com/apache/drill/pull/1348#discussion_r199230067
##########
File path: distribution/pom.xml
##########
@@ -485,6 +485,36 @@
</plugins>
</build>
</profile>
+ <profile>
+ <!-- this profile adds/overrides few features of the 'apache-release'
+ profile in the parent pom. -->
+ <id>apache-release</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.spotify</groupId>
+ <artifactId>dockerfile-maven-plugin</artifactId>
+ <version>1.4.3</version>
+ <executions>
+ <execution>
+ <id>docker-image</id>
+ <goals>
+ <goal>build</goal>
+ <goal>push</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <repository>drill/apache-drill-centos</repository>
Review comment:
1. This is configurable - anyone can update it to any private or public
Docker hub or any Container Registry. Do you have a different approach in mind?
2. I briefly touched upon this in the description. Since the ask was for an
official Docker image for AD, it makes sense to build this once during the
release. Anyone can download the Docker image at anytime, using a simple pull.
Everything else remains the same. I also chose this approach to prevent Docker
images from being generated everytime.
3. Tim and I have. We intend to give access to the 'drill' Docker Hub
Organization to all committers. Perhaps, starting with release managers for
every release. It's a good central place to have all related docker images for
Drill.
4. Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
