ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317161102
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java
##########
@@ -116,7 +116,7 @@ public boolean load(RecordBatchDef def, DrillBuf buf)
throws SchemaChangeExcepti
// If the field is a map, check if the map schema changed.
- } else if (vector.getField().getType().getMinorType() == MinorType.MAP
&&
+ } else if ((vector.getField().getType().getMinorType() ==
MinorType.MAP || vector.getField().getType().getMinorType() == MinorType.DICT)
&&
Review comment:
please extract the whole check within else-if to new method with descriptive
name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
