ihuzenko commented on a change in pull request #1981: DRILL-7583: Remove STOP
status from operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379455455
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -812,37 +877,43 @@ private void delayedSetup() {
* Initialize fields (that may be reused when reading spilled partitions)
*/
private void initializeBuild() {
- baseHashTable.updateIncoming(buildBatch, probeBatch); // in case we
process the spilled files
+ baseHashTable.updateIncoming(buildBatch, probeBatch); // in case we process
+ // the spilled files
// Recreate the partitions every time build is initialized
- for (int part = 0; part < numPartitions; part++ ) {
- partitions[part] = new HashPartition(context, allocator, baseHashTable,
buildBatch, probeBatch, semiJoin,
- RECORDS_PER_BATCH, spillSet, part, spilledState.getCycle(),
numPartitions);
+ for (int part = 0; part < numPartitions; part++) {
+ partitions[part] = new HashPartition(context, allocator, baseHashTable,
+ buildBatch, probeBatch, semiJoin, RECORDS_PER_BATCH, spillSet, part,
+ spilledState.getCycle(), numPartitions);
}
spilledInners = new HashJoinSpilledPartition[numPartitions];
}
/**
- * Note:
- * This method can not be called again as part of recursive call of
executeBuildPhase() to handle spilled build partitions.
+ * Note: This method can not be called again as part of recursive call of
+ * executeBuildPhase() to handle spilled build partitions.
*/
private void initializeRuntimeFilter() {
if (!enableRuntimeFilter || bloomFiltersGenerated) {
return;
}
- runtimeFilterReporter = new
RuntimeFilterReporter((ExecutorFragmentContext) context);
+ runtimeFilterReporter = new RuntimeFilterReporter(
+ (ExecutorFragmentContext) context);
Review comment:
There are a lot of new line breaks introduced in the class in situations
where the line is not actually long. Could you please revert the changes? I
would suggest considering line with length up to 100 symbols as normal. Phew...
Java is so verbal:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
