ihuzenko commented on a change in pull request #1981: DRILL-7583: Remove STOP
status from operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379458174
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -1222,63 +1329,81 @@ public HashJoinBatch(HashJoinPOP popConfig,
FragmentContext context,
for (int i = 0; i < conditions.size(); i++) {
SchemaPath rightPath = (SchemaPath) conditions.get(i).getRight();
- PathSegment.NameSegment nameSegment =
(PathSegment.NameSegment)rightPath.getLastSegment();
+ PathSegment.NameSegment nameSegment = (PathSegment.NameSegment) rightPath
+ .getLastSegment();
buildJoinColumns.add(nameSegment.getPath());
String refName = "build_side_" + i;
- rightExpr.add(new NamedExpression(conditions.get(i).getRight(), new
FieldReference(refName)));
+ rightExpr.add(new NamedExpression(conditions.get(i).getRight(),
+ new FieldReference(refName)));
}
this.allocator = oContext.getAllocator();
- numPartitions =
(int)context.getOptions().getOption(ExecConstants.HASHJOIN_NUM_PARTITIONS_VALIDATOR);
- if ( numPartitions == 1 ) { //
- disableSpilling("Spilling is disabled due to configuration setting of
num_partitions to 1");
+ numPartitions = (int) context.getOptions()
+ .getOption(ExecConstants.HASHJOIN_NUM_PARTITIONS_VALIDATOR);
+ if (numPartitions == 1) { //
Review comment:
```suggestion
if (numPartitions == 1) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
