ihuzenko commented on a change in pull request #1981: DRILL-7583: Remove STOP
status from operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379432493
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -445,32 +457,34 @@ private IterOutcome prefetchFirstBatch(IterOutcome
outcome,
outcome = sniffNonEmptyBatch(outcome, index, batch);
}
- isEmpty.setValue(outcome == IterOutcome.NONE); // If we received NONE
there is no data.
+ isEmpty.setValue(outcome == IterOutcome.NONE); // If we received NONE there
+ // is no data.
- if (outcome == IterOutcome.STOP) {
- // We reached a termination state
- state = BatchState.STOP;
- } else {
- // Got our first batch(es)
- if (spilledState.isFirstCycle()) {
- // Only collect stats for the first cycle
- memoryManagerUpdate.run();
- }
- state = BatchState.FIRST;
+ // Got our first batch(es)
+ if (spilledState.isFirstCycle()) {
+ // Only collect stats for the first cycle
+ memoryManagerUpdate.run();
}
-
+ state = BatchState.FIRST;
return outcome;
}
/**
- * Currently in order to accurately predict memory usage for spilling, the
first non-empty build or probe side batch is needed. This method
- * fetches the first non-empty batch from the probe or build side.
- * @param curr The current outcome.
- * @param inputIndex Index specifying whether to work with the prorbe or
build input.
- * @param recordBatch The probe or build record batch.
- * @return The {@link org.apache.drill.exec.record.RecordBatch.IterOutcome}
for the left or right record batch.
+ * Currently in order to accurately predict memory usage for spilling, the
+ * first non-empty build or probe side batch is needed. This method fetches
+ * the first non-empty batch from the probe or build side.
+ *
+ * @param curr
Review comment:
Is this curry? :) Please rename the parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
