ihuzenko commented on a change in pull request #1981: DRILL-7583: Remove STOP
status from operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379438432
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -515,99 +536,95 @@ public HashJoinMemoryCalculator getCalculatorImpl() {
@Override
public IterOutcome innerNext() {
if (wasKilled) {
- // We have received a kill signal. We need to stop processing.
- this.cleanup();
- super.close();
+ // We have received a cancel signal. We need to stop processing.
+ cleanup();
return IterOutcome.NONE;
}
prefetchFirstBuildBatch();
if (rightUpstream.isError()) {
- // A termination condition was reached while prefetching the first build
side data holding batch.
+ // A termination condition was reached while prefetching the first build
+ // side data holding batch.
// We need to terminate.
return rightUpstream;
}
try {
- /* If we are here for the first time, execute the build phase of the
- * hash join and setup the run time generated class for the probe side
+ /*
+ * If we are here for the first time, execute the build phase of the hash
+ * join and setup the run time generated class for the probe side
*/
if (state == BatchState.FIRST) {
// Build the hash table, using the build side record batches.
IterOutcome buildExecuteTermination = executeBuildPhase();
if (buildExecuteTermination != null) {
- // A termination condition was reached while executing the build
phase.
+ // A termination condition was reached while executing the build
+ // phase.
Review comment:
merge with line below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
