paul-rogers commented on a change in pull request #1997: DRILL-7604: Allow 
session options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384258199
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java
 ##########
 @@ -96,10 +101,13 @@ public QueryResult submitQueryJSON(QueryWrapper query) 
throws Exception {
   @Produces(MediaType.TEXT_HTML)
   public Viewable submitQuery(@FormParam("query") String query,
                               @FormParam("queryType") String queryType,
-                              @FormParam("autoLimit") String autoLimit) throws 
Exception {
+                              @FormParam("autoLimit") String autoLimit,
+                              Form form) throws Exception {
 
 Review comment:
   Ah, so you do have a solution for session options. Suggestion: since the two 
changes affect exactly the same code, just go ahead and combine them. You can 
create a roll-up JIRA that has the two specific JIRA tickets as sub-tasks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to