dobesv commented on a change in pull request #1997: DRILL-7604: Allow session 
options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384287008
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
 ##########
 @@ -131,6 +146,52 @@ public QueryResult run(final WorkManager workManager, 
final WebUserConnection we
     return new QueryResult(queryId, webUserConnection, 
webUserConnection.results);
   }
 
+  private void applyOptions(WebUserConnection webUserConnection) throws 
BadRequestException {
 
 Review comment:
   When the options come from the form, they do arrive as strings.  But if it 
is a JSON payload, then the options object values could be boolean, number, 
etc... any JSON value would be possible there.  I wanted to accept actual 
boolean / numeric values from a JSON payload rather than have them provide the 
booleans / number as string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to