paul-rogers commented on a change in pull request #1997: DRILL-7604: Allow
session options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384308531
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java
##########
@@ -96,10 +101,13 @@ public QueryResult submitQueryJSON(QueryWrapper query)
throws Exception {
@Produces(MediaType.TEXT_HTML)
public Viewable submitQuery(@FormParam("query") String query,
@FormParam("queryType") String queryType,
- @FormParam("autoLimit") String autoLimit) throws
Exception {
+ @FormParam("autoLimit") String autoLimit,
+ Form form) throws Exception {
Review comment:
You have the right idea in general. If we could approve and commit PRs
quickly, then smaller would absolutely be better. Unfortunately, it typically
takes a week (sometimes several) to get reviews done.
For historical reasons, commits are done only after running tests on a
non-public cluster. The folks who have access to that cluster run tests only
about once a week, typically on Fridays. To reduce work, that person does a
"batch commit", combines that week's commits into a single branch so tests can
be run once. It ain't pretty, but it is who things have been done for a long
time.
If your code conflicts with another PR (such as your own other change in the
same place), the committer will pick one of them, ask you to resolve conflicts,
and will then commit the other in the next commit batch a week or two later.
Given our (again, not pretty) process, you are better off combining
conflicting changes into a single PR.
This is, by the way, why some of my PRs are big: I can't wait months to get
it done in small pieces the way I "should" do it -- I'd completely forget what
I was doing several 2-3 week cycles.
We absolutely want to change it, but don't have a good way to run the
"pre-commit" tests except on that non-public cluster.
Any suggestions you've seen work on other projects?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
