paul-rogers commented on a change in pull request #1997: DRILL-7604: Allow
session options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r384260682
##########
File path: exec/java-exec/src/main/resources/rest/query/query.ftl
##########
@@ -83,6 +83,16 @@
Submit
</button>
<input type="checkbox" name="forceLimit" value="limit" <#if
model.isAutoLimitEnabled()>checked</#if>> Limit results to <input type="text"
id="autoLimit" name="autoLimit" min="0"
value="${model.getDefaultRowsAutoLimited()?c}" size="6" pattern="[0-9]*"> rows
<span class="glyphicon glyphicon-info-sign" title="Limits the number of records
retrieved in the query. Ignored if query has a limit already"
style="cursor:pointer"></span>
+ <label> Store Format
+ <select name="store.format">
+ <option value="parquet">Parquet</option>
+ <option value="json">JSON</option>
+ <option value="csv">Comma-Separated Values</option>
+ <option value="psv">Pipe-Separated Values</option>
+ <option value="tsv">Tab-Separated Values</option>
Review comment:
Should these be hard-coded? Other format plugins can offer the ability to
write to that format. Can they be used for a `CREATE TABLE`?
Also, it is annoying, but each plugin declares the formats that it supports.
As a result, the user could select `csv`, but that format might not be
available for a given file storage plugin. Or, there might be two: `csv` and
`csvh`.
Long story short, should we get this list from the plugin which can get it
from its list of supported writable formats?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
