I think for item 1 and 2, we should follow it. Continuous integration is very important to keep code quality and we should always keep CI pass. Only committer with write access can do merge.
But for item 0, if master branch fails, I think it's acceptable any committer check in a quick fix in master directly. On 2018/06/17 21:13:37, Mark Thomas <[email protected]> wrote: > On 17/06/18 16:46, Huxing Zhang wrote: > > Hi Community, > > > > I suggest we review the pull request merge policy. I've seen pull > > request merged but break the build. [1] > > > > My suggestion: > > > > 0. Change must use pull request, even for committers. > > 1. pull request must pass the CI build > > 2. pull request must be merged by another committer > > 3. pull request must pass review from at least one committer > > > > Thoughts? > > My recommendation is don't do it. > > You are creating multiple barriers to progress. Generally, social > controls result in a better community than technical controls. > > My suggestion is to ensure that emails about broken CI builds go to the > dev list and that there is a community expectation that if you break the > build you fix it ASAP. Further, if the build isn't fixed in a timely > manner then it should be acceptable for any committer to revert the > commit that broke the build if they wish. > > Of course, I'm not a committer here and this is just a recommendation. > > Mark >
