On Mon, Jun 18, 2018 at 5:13 AM, Mark Thomas <[email protected]> wrote: > On 17/06/18 16:46, Huxing Zhang wrote: >> Hi Community, >> >> I suggest we review the pull request merge policy. I've seen pull >> request merged but break the build. [1] >> >> My suggestion: >> >> 0. Change must use pull request, even for committers. >> 1. pull request must pass the CI build >> 2. pull request must be merged by another committer >> 3. pull request must pass review from at least one committer >> >> Thoughts? > > My recommendation is don't do it. > > You are creating multiple barriers to progress. Generally, social > controls result in a better community than technical controls. > > My suggestion is to ensure that emails about broken CI builds go to the > dev list and that there is a community expectation that
That's a good idea. How can we enable it? Currently the build failure email is only sent to the one who commits the change or the one who merges the pull request. I think it is better to go to dev list. Maybe we can ask the infra to do it. > if you break the > build you fix it ASAP. Further, if the build isn't fixed in a timely > manner then it should be acceptable for any committer to revert the > commit that broke the build if they wish. > > Of course, I'm not a committer here and this is just a recommendation. > > Mark -- Best Regards！ Huxing
