[email protected] +1 On Wed, Jun 20, 2018 at 9:39 AM Xin Wang <[email protected]> wrote:
> [email protected] +1 > > Huxing Zhang <[email protected]> 于2018年6月20日周三 上午9:32写道： > > > On Tue, Jun 19, 2018 at 11:08 PM, Huxing Zhang <[email protected]> > wrote: > > > On Mon, Jun 18, 2018 at 5:13 AM, Mark Thomas <[email protected]> wrote: > > >> On 17/06/18 16:46, Huxing Zhang wrote: > > >>> Hi Community, > > >>> > > >>> I suggest we review the pull request merge policy. I've seen pull > > >>> request merged but break the build. [1] > > >>> > > >>> My suggestion: > > >>> > > >>> 0. Change must use pull request, even for committers. > > >>> 1. pull request must pass the CI build > > >>> 2. pull request must be merged by another committer > > >>> 3. pull request must pass review from at least one committer > > >>> > > >>> Thoughts? > > >> > > >> My recommendation is don't do it. > > >> > > >> You are creating multiple barriers to progress. Generally, social > > >> controls result in a better community than technical controls. > > >> > > >> My suggestion is to ensure that emails about broken CI builds go to > the > > >> dev list and that there is a community expectation that > > > > > > That's a good idea. How can we enable it? Currently the build failure > > > email is only sent to the one who commits the change or the one who > > > merges the pull request. > > > I think it is better to go to dev list. Maybe we can ask the infra to > do > > it. > > > > > > After some googling, I found it can be configured in .travis.yml. > > [1] https://docs.travis-ci.com/user/notifications/ > > > > For example: > > > > notifications: > > email: > > - [email protected] > > > > > > [email protected] or [email protected], which one is > > better? > > > > Let us wait and see what others think. > > > > > > > >> if you break the > > >> build you fix it ASAP. Further, if the build isn't fixed in a timely > > >> manner then it should be acceptable for any committer to revert the > > >> commit that broke the build if they wish. > > >> > > >> Of course, I'm not a committer here and this is just a recommendation. > > >> > > >> Mark > > > > > > -- > > > Best Regards！ > > > Huxing > > > > > > > > -- > > Best Regards！ > > Huxing > > >
