Hi, Based on Justin's comments, I am changing my vote to +1 (binding) to release.
I've checked: * incubator in name * Disclaimer exists * sha512 chesum ok * signature ok * git tag matches * NOTICE and LICENSE exist in META-INF of jar files of binary release. * Unit test passed on Java 8 + OSX * Tested elegant shutdown with Tomcat 8.5.30 Minor issues: * The following UT sometime fails in my linux environment. AbstractInterfaceConfigTest.checkApplication1:90 expected:<10[0]> but was:<10[]> Need to take a look at it later, I've filed an issue here: https://github.com/apache/incubator-dubbo/issues/2227 On Wed, Aug 8, 2018 at 11:17 AM Justin Mclean <[email protected]> wrote: > > Hi, > > Having extra information in license or notice is unfortunate but IMO it's > just a documentation issue rather than a licensing error. I think it can > be fixed in the next release. > > Thanks, > Justin > > On Wed., 8 Aug. 2018, 11:36 am jun liu, <[email protected]> wrote: > > > > Each package MUST provide a LICENSE file and a NOTICE file which > > > account for the package's exact content. LICENSE and NOTICE MUST NOT > > > provide unnecessary information about materials which are not bundled > > > in the package, such as separately downloaded dependencies. > > > > > > So I suggest to fix this issue and redo the vote. > > > > > > [1] > > http://www.apache.org/legal/release-policy.html#licensing-documentation < > > http://www.apache.org/legal/release-policy.html#licensing-documentation> > > I am not sure if we need to redo the vote for this issue, I wonder what do > > other developers think? > > > > Best regards, > > Jun > > > > > On 7 Aug 2018, at 10:38, Huxing Zhang <[email protected]> wrote: > > > > > > Hi, > > > > > > Since we remove the hessian-lite, I suggest we remove the license info > > > in LICENSE. > > > > > > I checked ASF release policy[1], it says: > > > > > > Each package MUST provide a LICENSE file and a NOTICE file which > > > account for the package's exact content. LICENSE and NOTICE MUST NOT > > > provide unnecessary information about materials which are not bundled > > > in the package, such as separately downloaded dependencies. > > > > > > So I suggest to fix this issue and redo the vote. > > > > > > [1] > > http://www.apache.org/legal/release-policy.html#licensing-documentation > > > > > > > > > > > > On Mon, Aug 6, 2018 at 1:59 PM Jun Liu <[email protected]> wrote: > > >>> Hello Dubbo Community, > > >> > > >> This is a call for vote to release Apache Dubbo (Incubating) version > > 2.6.3. > > >> > > >> The release candidates (RC3): > > >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3 > > >> > > >> Git tag for the release (RC3): > > >> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3 > > >> > > >> Hash for the release tag: > > >> 22899a4b395411496ebf03c514e7674e8073e0c3 > > >> > > >> Release Notes: > > >> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md > > >> > > >> The artifacts have been signed with Key : 28681CB1, which can be found > > in the keys file: > > >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > > >> > > >> The vote will be open for at least 72 hours or until necessary number > > of votes are reached. > > >> > > >> Please vote accordingly: > > >> > > >> [ ] +1 approve > > >> [ ] +0 no opinion > > >> [ ] -1 disapprove with the reason > > >> > > >> The previously RC2 vote thread: > > >> > > https://lists.apache.org/thread.html/39a25c905a46e7281b96f98a23f795c796616a9a20623c0bed8b90db@%3Cdev.dubbo.apache.org%3E > > >> > > >> Thanks, > > >> The Apache Dubbo (Incubating) Team > > >> > > > > > > > > > -- > > > Best Regards！ > > > Huxing > > > > -- Best Regards！ Huxing
