+1 (binding) to release.

I have checked:
* All UTs passed with Java 7+, MacOSX,
* Sha512 checksum ok,
* All codes in RC3 matched with tag 22899a4b395411496ebf03c514e7674e8073e0c3
* Ran integration tests with samples under dubbo/dubbo-samples[1], all passed.

Issues to notice:
* I encountered the same issue Huxing has mentioned. 
AbstractInterfaceConfigTest.checkApplication1:90 sometimes failed on my Linux.
This UT aims to test whether  
'System.setProperty(Constants.SHUTDOWN_WAIT_SECONDS_KEY)’  can be invoked 
automatically by ApplicationConfig. I have gave a thorough search on this 
feature, and it turns out that it works fine. The main reason for the failure 
is that different UTs interact with each other, which means different execution 
orders often produce different results. For this specific reason, I have found 
that 'com.alibaba.dubbo.config.RegistryConfigTest#testWait’ also operates on 
the same property: 

public void testWait() throws Exception {
    RegistryConfig registry = new RegistryConfig();
    assertThat(registry.getWait(), is(10));
    assertThat(System.getProperty(Constants.SHUTDOWN_WAIT_KEY), equalTo("10"));
    System.clearProperty(Constants.SHUTDOWN_WAIT_KEY); // Add this snippet, 
problem got disappeared.

To conclude, it’s not a real bug, so I think we can improve the stability of 
UTs during the following releases

> On 6 Aug 2018, at 13:59, Jun Liu <liu...@apache.org> wrote:
> Hello Dubbo Community,
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
> The release candidates (RC3):
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> Git tag for the release (RC3):
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> Hash for the release tag:
> 22899a4b395411496ebf03c514e7674e8073e0c3
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.3/CHANGES.md
> The artifacts have been signed with Key : 28681CB1, which can be found in the 
> keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
> Please vote accordingly:
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason
> The previously RC2 vote thread:
> https://lists.apache.org/thread.html/39a25c905a46e7281b96f98a23f795c796616a9a20623c0bed8b90db@%3Cdev.dubbo.apache.org%3E
> Thanks,
> The Apache Dubbo (Incubating) Team

Reply via email to