@beiwei, @yuhang 1. https://github.com/apache/incubator-dubbo/pull/3344 SkipFailbackWrapperException is added at 2012-07-13 , but never used ,I think it should be added when it is needed。
2.https://github.com/apache/incubator-dubbo/pull/3371 Diamond Operator is a feature in jdk7. KimmKing <[email protected]> 于2019年1月26日周六 上午1:51写道： > > > > >> like Lambda , Diamond Operator > > > Since dubbo only support jdk8+, it should be an important task for us. > > > > > At 2019-01-25 12:18:56, "[email protected]" <[email protected]> > wrote: > > | > +1 > Agree with youre opinion! > > > 您的朋友：刘志广 > > > > From: LiZhenNet > Date: 2019-01-25 11:24 > To: dev > Subject: [Discuss] About Clean Code Plan > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused > methods ,unused logic , nonstandard naming in the code. And there are some > code that can use the new features of java to make the code more concise > and understandable. like Lambda , Diamond Operator and so on.These are easy > to find and fixed because of the tips of the idea .We should do it before > completing the incubation. > |
