Hi, On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <[email protected]> wrote: > > Hi, Huxing & LiZhen > > Things like diamond is something called grammar SUGAR. > Tasted good for developers but the same on byte code. > > So in my opinion we should not take it as a kind of "policy correct". > we can make the changes in the code of recent PRs but not for all the code. > Think about there may be more sugars in future JVM.
I think any changes should be "reviewable". I don't think we can change all the things in one pull request. Instead, we should divide it into small ones and make it easy to be reviewed. Recently I've seen several pull requests doing things like this. I think they are very good examples. > > best regards, > > Jason > > > On Jan 29, 2019, at 10:42, yuhang xiu <[email protected]> wrote: > > > > Your pr has modified more than 30,000 lines of code, and most of them are > > modifications of the entire file. > > What is the meaning of your pr? Why do I need to keep it open? > > > > If you need to discuss, issues and mailing lists are good choices, why do > > you need to discuss pr? > > > > Who can review this pr[1] and tell me what this pr is going to do? > > > > [1] https://github.com/apache/incubator-dubbo/pull/3371 > > > > LiZhenNet <[email protected]> 于2019年1月29日周二 上午10:29写道： > > > >> Yes, we can create a project to manage it, and we can talk about it. like: > >> Should we used Diamond Operator replace explicit type? Use Lambda? > >> Let's discuss the two pull requests above instead of closed it immediately. > >> > >> > >> > >> > >> > >> Huxing Zhang <[email protected]> 于2019年1月29日周二 上午9:58写道： > >> > >>> Hi, > >>> > >>> Nice suggestion! > >>> > >>> Shall we can create a project to manage it? > >>> > >>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <[email protected]> > >> wrote: > >>>> > >>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of > >> unused > >>>> methods ,unused logic , nonstandard naming in the code. And there are > >>> some > >>>> code that can use the new features of java to make the code more > >> concise > >>>> and understandable. like Lambda , Diamond Operator and so on.These are > >>> easy > >>>> to find and fixed because of the tips of the idea .We should do it > >> before > >>>> completing the incubation. > >>> > >>> > >>> > >>> -- > >>> Best Regards！ > >>> Huxing > >>> > >> > -- Best Regards！ Huxing
