Hi, I also suggest the reviewer to follow the standard reviewing process[1], rather than just leave a comment. To me, the advantage are as follows: - review status will be displayed in pull request, one can easily identify pull request that is in "request change" so that you won't look into it again. - all the review stats/activities will be collected by dubbo-bot and summarized in the weekly report.
[1] https://help.github.com/en/articles/approving-a-pull-request-with-required-reviews On Thu, Mar 7, 2019 at 5:04 PM Huxing Zhang <[email protected]> wrote: > > Hi, > > When I am looking at the pull request, I found a pull request[1] got > approved by 2 of our reviewers(committers), but still not getting > merged. > > I am thinking why it is like this. Should we set up community rules > for thing like this? > For example, if a pull request has got at least N approval from > committers, it can be merged, where N can be discussed. The more > approval it need, the longer process it will take. > > For large size pull requests, the reviewer can request another one to > help on it. > > I would suggest to keep it small, N=1. Even the reviewer fails to > identify the issues, it can be fixed by sending another pull request. > > How do you think? > > [1] https://github.com/apache/incubator-dubbo/pull/3536 > > -- > Best Regards！ > Huxing -- Best Regards！ Huxing
