For this particular PR, the reason I approved but not merged it is that I think the code change itself is ok but I don’t understand the connection with the issue the author claims to solve. I plan to merge it after fully understand, unfortunately, I just forgot to check the feedback.
Jun > On Mar 7, 2019, at 5:27 PM, Huxing Zhang <[email protected]> wrote: > > Hi, > > On Thu, Mar 7, 2019 at 5:12 PM LiZhenNet <[email protected] > <mailto:[email protected]>> wrote: >> >> Hi， >> I don’t think it’s a problem about number of reviewers , As time goes by, >> we will slowly ignore it,We pay more attention to the new issue. > > Are you suggesting not to set up such a hard limit? > It just looks strange to me, that 2 of the reviewer (with write > access) has approve the pull request, but it is not getting merged. > So what does the 2 approval mean? > >> >> >> >> Huxing Zhang <[email protected]> 于2019年3月7日周四 下午5:04写道： >> >>> Hi, >>> >>> When I am looking at the pull request, I found a pull request[1] got >>> approved by 2 of our reviewers(committers), but still not getting >>> merged. >>> >>> I am thinking why it is like this. Should we set up community rules >>> for thing like this? >>> For example, if a pull request has got at least N approval from >>> committers, it can be merged, where N can be discussed. The more >>> approval it need, the longer process it will take. >>> >>> For large size pull requests, the reviewer can request another one to >>> help on it. >>> >>> I would suggest to keep it small, N=1. Even the reviewer fails to >>> identify the issues, it can be fixed by sending another pull request. >>> >>> How do you think? >>> >>> [1] https://github.com/apache/incubator-dubbo/pull/3536 >>> >>> -- >>> Best Regards！ >>> Huxing >>> > > > > -- > Best Regards！ > Huxing
