horoc commented on code in PR #2793: URL: https://github.com/apache/incubator-eventmesh/pull/2793#discussion_r1061237019
########## eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/recommend/EventMeshRecommendImpl.java: ########## @@ -31,179 +31,233 @@ import java.util.List; import java.util.Map; -import lombok.extern.slf4j.Slf4j; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; -@Slf4j Review Comment: hi, @jonyangx , `slf4j` log annotation here was introduced in this PR #2761 recently by @weihubeats , may I know why do you want to remove it? maybe we need to discuss and make a consensus to use a unified solution for the whole project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
