horoc commented on code in PR #2793: URL: https://github.com/apache/incubator-eventmesh/pull/2793#discussion_r1061294933
########## eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/recommend/EventMeshRecommendImpl.java: ########## @@ -31,179 +31,233 @@ import java.util.List; import java.util.Map; -import lombok.extern.slf4j.Slf4j; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; -@Slf4j Review Comment: > OK, I could fix it using lombok,but it's not good for vim/ultraedit ide. @jonyangx , I think your concern about the inconvenience of developers who use other IDE is reasonable. In my point of view, if you think it's better to remove Lombok dependencies, you can raise a new issue to discuss this point, and after discussion, if it's really necessary, we can do an optimization in a new pr to remove all Lombok annotations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
