weihubeats commented on code in PR #2793: URL: https://github.com/apache/incubator-eventmesh/pull/2793#discussion_r1061295028
########## eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/recommend/EventMeshRecommendImpl.java: ########## @@ -31,179 +31,233 @@ import java.util.List; import java.util.Map; -import lombok.extern.slf4j.Slf4j; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; -@Slf4j Review Comment: If we want to print the log we just need to add the comment @Slf4j, without writing similar code ` private static final Logger LOG = LoggerFactory.getLogger(WeightRoundRobinLoadBalanceSelector.class); ` In practice, sometimes we will find some complex code xx.class in the project is wrong, and not the actual printing log class, so that we can reduce the workload of printing logs and improve development efficiency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
