horoc commented on code in PR #2793: URL: https://github.com/apache/incubator-eventmesh/pull/2793#discussion_r1061285639
########## eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/recommend/EventMeshRecommendImpl.java: ########## @@ -31,179 +31,233 @@ import java.util.List; import java.util.Map; -import lombok.extern.slf4j.Slf4j; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; -@Slf4j Review Comment: Actually, we do have lots of Lombok annotations in the project, like `@Data`, `@Builder`, `@Slf4j`, and as @jonyangx mentioned, it's true that there is some shortage of Lombok annotation, the developers need to do extra configuration in IDE to enable Lombok parsing. But in the meantime, Lombok also has provided its own convenience for developers. I think the key point is, we need to keep a consistent code style for the whole project, otherwise, we may modify the same place back and forth by different developers. 😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
