[
https://issues.apache.org/jira/browse/FALCON-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875016#comment-13875016
]
Venkatesh Seetharam commented on FALCON-246:
--------------------------------------------
Few minor issues (although I'm a newbie to activemq):
* EmbeddedBroker is defined in both messaging and prism modules, prism
should use one defined in messaging
* Why not use leveldb instead of kahadb
(http://stackoverflow.com/questions/7463415/activemq-performance-gotchas-and-precautions)
* The Broker factory sets all defaults and is that really necessary to do?
* LOGGER.debug statements could be combined and also enclosed with check if
(LOG.isDebugEnabled())
* I'd avoid excluding a class from findbugs but instead only disable a
method if you cant fix using findbugs annotation which is already a mvn
dependency
* I do not see any changes in FalconCLI class - also removed from findbugs
* You have added an additional messaging interface in the examples instead
of changing version on the existing interface (embedded-cluster.xml and
standalone)
* Why do we need geronimo-jms_1.1_spec?
* Why do you need activemq dependency in oozie? It should be available as a
transitive dependency from falcon-messaging
* activemq-kahadb-store is a hard dependency now. Do we need it?
* Also, kahadb is not shipped as part of a cluster setup. Have you verified
integration-tests run?
* For lack of a patch build in jenkins, appreciate if you could verify int
tests: export MAVEN_OPTS="-Xmx1024m -XX:MaxPermSize=256m" && mvn clean verify
> Upgrade to ActiveMQ 5.9.0
> -------------------------
>
> Key: FALCON-246
> URL: https://issues.apache.org/jira/browse/FALCON-246
> Project: Falcon
> Issue Type: Improvement
> Components: messaging
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Attachments: FALCON-246.patch
>
>
> ActiveMQ 5.9.0 brings a lot of improvements, especially in terms of
> performance.
> I gonna submit a set of patches for this upgrade and leverage the different
> configurations including performance improvements (kahadb, leveldb, etc) in
> embedded mode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
