[
https://issues.apache.org/jira/browse/FALCON-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875050#comment-13875050
]
Jean-Baptiste Onofré commented on FALCON-246:
---------------------------------------------
Hi Venkatesh, to answer to your questions:
- EmbeddedBroker in messaging is just to testing purpose. I tried to use the
one from prism but it introduced a Maven cyclic dependency (as prism depends to
messaging).
- LevelDB is more efficient but it suffers to a couple of issues in 5.9.0. By
the way, the default persistence adapter in 5.9.0 is still KahaDB (that's why I
use introspection). I will update to LevelDB when LevelDB will be the default
one in ActiveMQ or with the update to ActiveMQ 5.9.1 (which will fix LevelDB
issues).
- The broker factory does more than default. If you take a look on the system
usage for instance, it's not the default one. More over, some parameters (like
destination policy) are the default only when you use a Spring activemq.xml
(like in the ActiveMQ distribution). That's why I "forced" the optimization
(system usage, kahadb, etc).
- LOGGER.debug needs isDebugEnabled only when using log4j. As I proposed to use
slf4j, with slf4j, isDebugEnabled() is no more required due to the usage of {}
(parametrized).
- +1 for findbugs, my bad, I will fix that.
- +1 FalconCLI excluded from findbugs was for another issue (to be able to
build and test completely).
- I didn't add messaging interface, I just changed the version of the existing
one. Let me check the patch content.
- I see a dependency problem. For instance, messaging doesn't really use
ActiveMQ, it's a pure JMS client. So if users use an external broker (let say
WebSphere MQ or Sonic MQ), we embed ActiveMQ broker for nothing. Just JMS spec
is required. That's why I break the ActiveMQ dependency to be more generic when
using external brokers (not necessary ActiveMQ).
- +1 I changed it after.
- activemq-kahadb-store is required to "inject" and define the KahaDB
optimization.
- I tested in embedded mode + itests. You are right, I re-run a complete itests
+ manual test in both embedded and distributed.
- +1 I re-do it now (I always do mvn clean install assembly:assembly before
submitting a patch).
Thanks for the questions !
Regards
JB
> Upgrade to ActiveMQ 5.9.0
> -------------------------
>
> Key: FALCON-246
> URL: https://issues.apache.org/jira/browse/FALCON-246
> Project: Falcon
> Issue Type: Improvement
> Components: messaging
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Attachments: FALCON-246.patch
>
>
> ActiveMQ 5.9.0 brings a lot of improvements, especially in terms of
> performance.
> I gonna submit a set of patches for this upgrade and leverage the different
> configurations including performance improvements (kahadb, leveldb, etc) in
> embedded mode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
