[
https://issues.apache.org/jira/browse/FALCON-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878750#comment-13878750
]
Shaik Idris Ali commented on FALCON-246:
----------------------------------------
1. Also, if we are using embedded broker then it should be used across all the
classes which starts broker service:
HadoopStartupListener
FalconPostProcessingTest
ActiveMQTest
2. EmbeddedBroker.java is defined at two places
messaging/src/test/java/org/apache/falcon/messaging/EmbeddedBroker.java
prism/src/main/java/org/apache/falcon/util/EmbeddedBroker.java
It should be placed in common place like test-util.
3. In EmbeddedBroker.java
IntrospectionSupport.setProperties(brokerService.getPersistenceAdapter(),
properties);
will override all previously set properties ??
4. Instead of multiple log statements, prefer to loop throught properties
object.
At last, I am not sure, what have we upgraded here, For testcases I don't think
we need 5.9.0, and Falcon is independent of JMS implementation.
> Upgrade to ActiveMQ 5.9.0
> -------------------------
>
> Key: FALCON-246
> URL: https://issues.apache.org/jira/browse/FALCON-246
> Project: Falcon
> Issue Type: Improvement
> Components: messaging
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Attachments: FALCON-246.patch
>
>
> ActiveMQ 5.9.0 brings a lot of improvements, especially in terms of
> performance.
> I gonna submit a set of patches for this upgrade and leverage the different
> configurations including performance improvements (kahadb, leveldb, etc) in
> embedded mode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
