[
https://issues.apache.org/jira/browse/FALCON-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878812#comment-13878812
]
Jean-Baptiste Onofré commented on FALCON-246:
---------------------------------------------
Hi Shaik, as I said to Venkatesh:
1 and 2/ right, but it introduces a Maven cyclic dependency. I would propose to
have a dedicated module embedded-broker shared by prism and the other modules.
I can update the patch this way.
3/ It override the KahaDB properties (not the previously defined properties).
However, I think it's clearer to get the persistence adapter explicitly. I will
update the patch this way.
4/ Good idea (even at the end, it's the same for performance, but the code is
cleaner).
In what I saw, Falcon depends to ActiveMQ in some area. For instance, the rerun
module explicitly uses a ActiveMQQueue (to be more flexible, it should use a
generic JMS Queue).
For the test case, we use ActiveMQ broker just to have a broker (any JMS broker
can do the same, but I think ActiveMQ is a good one). I'm agree that we don't
have to use EmbeddedBroker in unit tests, but I think it's better as we test
exactly what we provide in the distribution.
What do you mean by "At last, I am not sure, what have we upgraded here".
To summarize, I propose:
1/ to refactore the patch to create embedded-broker Maven module dedicated to
the ActiveMQ broker configuration. This module will be use in prism (at
startup) and other modules (only for the tests).
2/ a patch to avoid to use ActiveMQ explicitly in rerun and use a "pure" JMS
client.
3/ replace the IntrospectionSupport with explicit persistence adapter
configuration injection.
4/ iterate on properties to provide the log statements
WDYT ?
> Upgrade to ActiveMQ 5.9.0
> -------------------------
>
> Key: FALCON-246
> URL: https://issues.apache.org/jira/browse/FALCON-246
> Project: Falcon
> Issue Type: Improvement
> Components: messaging
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Attachments: FALCON-246.patch
>
>
> ActiveMQ 5.9.0 brings a lot of improvements, especially in terms of
> performance.
> I gonna submit a set of patches for this upgrade and leverage the different
> configurations including performance improvements (kahadb, leveldb, etc) in
> embedded mode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
