On 2/26/18 10:48 AM, Myrle Krantz wrote: > Hey Phil, > > Thanks for the feedback. I've just updated the artifact ids to apache > fineract. It's not the only place we need to replace Mifos with > Apache Fineract though. > > Other places are: > * the package names > * a couple of variables in build scripts > * the copyright notice headers in the source files. > > On that last point I have a question which you are probably a good > person to ask: Can I just replace Mifos and Kuelap with Apache? Or we > need to do something more complicated there.
We should replace the source headers with standard headers. The SGA entitles us to do that. We *can* include copyright notices citing the original authors in NOTICE.txt, but should only do so if that has been requested by the grantors. > > In the mean time, and with apologies, I strongly suggest you repull > all the fineract repositories so that you are working with up-to-date > artifact ids. I just did that. To make this easier, I created a list of repos based on the github query you posted. I use bash one-liners to do the clones, pulls and (attempted) builds. For example, the build locally one does this: cat $1 | while read in; do cd "$in"; echo "updating and publishing $in"; git pull; chmod +x gradlew; ./gradlew PublishToMavenRepo; cd ..; done where the command line arg is the file with just the repo names in it. The problem I am now having is that the order of the repos in the file is just random and there appears to be a required build order. I am pretty new to gradle, but in maven the reactor would take care of figuring that out. I will try to figure it out and fix the order of the file, clean up the scripts and post them somewhere. Or someone who actually knows gradle can create something like a fineract-cn-parent thingy whose build does all of this. Or I learn that this is all easily done using some gradle commands that I don't know :) Phil > > Best Regards, > Myrle > > > > On Mon, Feb 26, 2018 at 6:25 PM, Phil Steitz <[email protected]> wrote: >> On 2/26/18 12:52 AM, Markus Geiss wrote: >>> Hey Phil, >>> >>> given all repos got pushed as is, I guess one of the first tasks is to >>> rename >>> all packages and projects to fit into the Apache layout. >>> >>> If you just want to get started now, you need to call >>> >>> ./gradelw publishToMavenLocal (assuming a *nix OS) >>> >>> for every project. You should be able to adjust and run the >>> initial setup script found at the demo-server. >> Thanks, Markus. I have started just doing the installs using the >> mifos packaging. Once I get that working, I will start working on a >> repackaging PR. >> >> Phil >>> Cheers >>> >>> Markus >>> >>> .::Yagni likes a DRY KISS::. >>> >>> On Sun, Feb 25, 2018 at 10:18 PM Phil Steitz <[email protected]> wrote: >>> >>>> I would like to start contributing to CN. I have cloned all of the >>>> repos and thought it would be a good first step to build the >>>> demo-server. The readme for that component says that as a >>>> precondition, "All Mifos I/O projects must be published to your >>>> local Maven repository." I assume that now means some subset of all >>>> of the fineract-cn components. But in build.gradle, I see >>>> references to mifos components. Do I maybe need to just replace >>>> these with the fineract-cn versions and install these locally using >>>> "gradle publisToMavenLocal" from each of these repos? >>>> >>>> I am happy to provide doco and config patches as I get this working >>>> if I can get pointed in the right direction. Thanks in advance! >>>> >>>> Phil >>>> >>>>
