Hi Isaac, Thanks for volunteering to take up the above tasks.
Myrle, thank you for the needed tips and directions. Isaac, While you are at it, you might want to go inorder according to the dependency graph. >From what I have seen, here is how the order goes: lang, api, cassandra, mariadb, async, command, test, crypto, anubis, service-starter, identity, permitted-feign-client, accounting, customer, provisioner, rhythm, office, portfolio, deposit-account-management, cheques, teller, payroll, group, reporting. Where the current project (might) depends on the previous ones. So that the builds should not be failing as you move ahead. So you might want to begin with lang. Thanks, Awasum On Tue, Feb 27, 2018 at 7:34 PM, Myrle Krantz <[email protected]> wrote: > Hey Isaac, > > On Tue, Feb 27, 2018 at 3:38 PM, Isaac Kamga <[email protected]> > wrote: > >> Other places are: > >> * the package names > >> * a couple of variables in build scripts > >> * the copyright notice headers in the source files. > >> > > > > Can I take on these tasks viz updating other places in the code base such > > as package names, copyright information, etc ? > > Oh please do. Can you start with the copyright notices, since that > task can done be one repository at a time, and doesn't have > cross-repository effects? A couple of tips while you're doing this: > * I suggest doing one repository first, and letting us review it, > before doing the rest of the repositories. > * In projects without sub-modules, all you'll need to do is change the > license section in the build.gradle file. Then run the license task > and it should change all the headers in the project in one step. > * In projects with sub-modules, it's kind of the same except that the > block of code to change is in the shared.gradle file. > * Some projects have "skip existing" set. You'll have to remove that > setting, or the license task won't change anything. > > I'll not do anything else while you're doing that, since you'll have > to touch every file in the repositories, and merges would be required. > > > I have just sent in a Pull Request > > <https://github.com/apache/fineract-cn-demo-server/pull/2> to the > > demo-server repository updating the initial-setup and pull-all scripts > for > > review. > > I will review it tomorrow morning (Berlin timezone). Right now, I'm > too tired to properly check code. > > Best Regards, > Myrle >
