Hi Myrle, Thanks for taking out some time to review and merge the Pull Request.
I have just updated the copyright information and package name on the fineract-cn-lang repository and sent in another pull request <https://github.com/apache/fineract-cn-lang/pull/3> for review. On a related note, I'd like to ask experienced developers on Fineract CN if it would be necessary to change the project's name ( from *lang* to *fineract-cn-lang* ) in the settings.gradle <https://github.com/apache/fineract-cn-lang/blob/develop/settings.gradle> file. Also, in the bintray.pkg section of the build.gradle file <https://github.com/apache/fineract-cn-lang/blob/develop/build.gradle>, should the `repo` , `userOrg` and `vcsUrl` variables be changed too ? These will help with subsequent updates to fineract-cn-api, fineract-cn-cassandra, etc. At Your Service, Isaac Kamga On Tue, Feb 27, 2018 at 8:02 PM, Isaac Kamga <[email protected]> wrote: > Hi Myrle, > > +Awasum > > Thanks for all the awesomeness ! > > @Myrle, While awaiting your review of the PR, I'll be on those tasks. > > @Awasum, thanks for the dependency graph, it's definitely very helpful. > > At Your Service, > Isaac Kamga. > > > On Tue, Feb 27, 2018 at 7:55 PM, Awasum Yannick <[email protected]> wrote: > >> Hi Isaac, >> >> Thanks for volunteering to take up the above tasks. >> >> Myrle, thank you for the needed tips and directions. >> >> Isaac, While you are at it, you might want to go inorder according to the >> dependency graph. >> >> From what I have seen, here is how the order goes: >> >> lang, api, cassandra, mariadb, async, command, test, crypto, anubis, >> service-starter, identity, permitted-feign-client, accounting, customer, >> provisioner, rhythm, office, portfolio, deposit-account-management, >> cheques, teller, payroll, group, reporting. >> >> Where the current project (might) depends on the previous ones. So that >> the >> builds should not be failing as you move ahead. >> >> So you might want to begin with lang. >> >> >> >> Thanks, >> Awasum >> >> >> >> On Tue, Feb 27, 2018 at 7:34 PM, Myrle Krantz <[email protected]> wrote: >> >> > Hey Isaac, >> > >> > On Tue, Feb 27, 2018 at 3:38 PM, Isaac Kamga <[email protected]> >> > wrote: >> > >> Other places are: >> > >> * the package names >> > >> * a couple of variables in build scripts >> > >> * the copyright notice headers in the source files. >> > >> >> > > >> > > Can I take on these tasks viz updating other places in the code base >> such >> > > as package names, copyright information, etc ? >> > >> > Oh please do. Can you start with the copyright notices, since that >> > task can done be one repository at a time, and doesn't have >> > cross-repository effects? A couple of tips while you're doing this: >> > * I suggest doing one repository first, and letting us review it, >> > before doing the rest of the repositories. >> > * In projects without sub-modules, all you'll need to do is change the >> > license section in the build.gradle file. Then run the license task >> > and it should change all the headers in the project in one step. >> > * In projects with sub-modules, it's kind of the same except that the >> > block of code to change is in the shared.gradle file. >> > * Some projects have "skip existing" set. You'll have to remove that >> > setting, or the license task won't change anything. >> > >> > I'll not do anything else while you're doing that, since you'll have >> > to touch every file in the repositories, and merges would be required. >> > >> > > I have just sent in a Pull Request >> > > <https://github.com/apache/fineract-cn-demo-server/pull/2> to the >> > > demo-server repository updating the initial-setup and pull-all scripts >> > for >> > > review. >> > >> > I will review it tomorrow morning (Berlin timezone). Right now, I'm >> > too tired to properly check code. >> > >> > Best Regards, >> > Myrle >> > >> > >
