UncleGedd commented on issue #72:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/72#issuecomment-1073122703
Ok, I may have stumbled into a super simple solution here. In
`getInitialSettings.js` we set:
```
settings.autostart = get('data-autostart') === 'false' ? false : true;
```
This causes userale to start up automatically unless the `data-autostart`
property is explicity set to `false`. Which in the case of an NPM package, will
not be set at all. This can be averted by simply inverting the logic to:
```
settings.autostart = get('data-autostart') === 'true' ? true : false;
```
With this change, in an NPM deployment, the `start` function must be called
before userale will start working, and in the case of a script deployment,
users must set `data-autostart` to `true`. This is of course a breaking change
for script users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
