kevbrowndev commented on issue #72: URL: https://github.com/apache/incubator-flagon-useralejs/issues/72#issuecomment-1073342973
In order to prevent breaking changes, what about this? In Userale, the configure() function could be altered at line 32 so that if autostart is set via the options() function, as could happened if userale is being used as an npm package, that value trumps the getInitialSettings() version of autostart. This way, the code should work the same as it does now, unless autostart value is set to true in the Userale.options() function. In that case, no Userale logs would be sent. https://github.com/apache/incubator-flagon-useralejs/blob/master/src/configure.js On Sun, Mar 20, 2022, 11:53 AM Rob ***@***.***> wrote: > With this change, in an NPM deployment, the start function must be called > before userale will start working, and in the case of a script deployment, > users must set data-autostart to true. This is of course a breaking > change for script users > > Instead of making a breaking change for script users, is there perhaps a > way to detect whether we are in a script vs NPM deployment? Maybe we can > make use of available environment variables? (though that implies a build > process) > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-flagon-useralejs/issues/72#issuecomment-1073279453>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAOZLZ2SBLTIYHL6MNBRB7TVA5CXFANCNFSM4ZXVGRIQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
