kevbrowndev commented on issue #72:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/72#issuecomment-1073128463
Yes, thank you, I noticed this too! I was wondering if there was some
reason for it.
How to properly test this fix? Do you think it would be a good idea to add
a second, separate journey test, that tested autostart = false?
On Sat, Mar 19, 2022, 6:34 PM UncleGedd ***@***.***> wrote:
> Ok, I may have stumbled into a super simple solution here. In
> getInitialSettings.js we set:
>
> settings.autostart = get('data-autostart') === 'false' ? false : true;
>
> This causes userale to start up automatically unless the data-autostart
> property is explicity set to false. Which in the case of an NPM package,
> will not be set at all. This can be averted by simply inverting the logic
> to:
>
> settings.autostart = get('data-autostart') === 'true' ? true : false;
>
> With this change, in an NPM deployment, the start function must be called
> before userale will start working, and in the case of a script deployment,
> users must set data-autostart to true. This is of course a breaking
> change for script users
>
> —
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-flagon-useralejs/issues/72#issuecomment-1073122703>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAOZLZ3UIGFYSI4O44H6L6DVAZI7ZANCNFSM4ZXVGRIQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
>
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
>
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
