kevbrowndev commented on pull request #234:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1078629633
Thank you so much for looking at this!
Stop doesn't work in practice because the setup function sets on to true if
the following condition is true when setup is running:
if (state === 'interactive' || state === 'complete')
So on just keeps getting reset to true.
The unit test is too simple. But I guess unit tests are simple by nature.
:-)
On Thu, Mar 24, 2022, 11:39 PM poorejc ***@***.***> wrote:
> Have been doing some testing...
>
> confirm that below is broken for .options API in .js context (checked
> using webpackexample):
>
> userale.options({
> autostart:false
> });
>
> however below works for .html context:
>
> <script
> src="../build/userale-2.2.0.min.js"
> data-autostart="false"
> ></script>
>
> This is a bug!
>
> for .js context (e.g., usage with NPM module) intended workflow should be:
>
> import * as userale from 'flagon-userale';
>
> userale.options({
> 'autostart': false
> )}
>
> userale.start();
>
> that being said, we've debated whether this should be intended workflow or
> whether 'autostart' should default to 'false'.
>
> also, I can't get .stop() to work in either module or script-tag.
> 'userale.stop()' should halt the logging process. Not sure how unit tests
> are passing--they look right.
>
> Really good ticket. I'll test out this branch now and see if new merge ops
> work.
>
> —
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1078622365>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAOZLZ55N6BUQIVAYNDKK53VBUYORANCNFSM5RPXDKAQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
