kevbrowndev commented on pull request #234:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1079425705
Sounds good! We're counting on you as always, uncleGedd! :-)
So, we have stop, start functions, and a property called autostart...
They should all work together.
Autostart=false should stop all logging until start is run.
Stop() should stop all logging until start() is run.
So if a user puts autostart = false in options(), she should be able to at
any time or place in the code start logging again by calling the start()
function?
If a user sets autostart = true in options, he should be able to at any
place in the code stop logging by calling stop()?
On Fri, Mar 25, 2022, 9:25 AM poorejc ***@***.***> wrote:
> I'll take a look at your branch tonight. Thanks!
> … <#m_8627391389805741626_>
>
> just updated my last comment--I have a hack not a solution, but I think it
> helps show us what's broken and what we need to figure out--we need to
> escape setup(), and figure out a new solution for how to retry setup() when
> the DOM isn't fully loaded.
>
> don't want to suggest that this is the right thing to do, this was just an
> expermient:
>
> } else {
>
> attachHandlers(config);
>
> }
>
>
> Happy to keep helping, I'm fully expecting @UncleGedd
> <https://github.com/UncleGedd> to immediately see the solution, though :)
>
> —
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-flagon-useralejs/pull/234#issuecomment-1079025728>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAOZLZY2HW5ZYUGLDEBNLM3VBW5E5ANCNFSM5RPXDKAQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
